Raphael Kubo da Costa wrote on Sat, Sep 01, 2012 at 11:05:02 -0300:
> Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:
>
> > 2012-08-31 20:32:05 Raphael Kubo da Costa napisał(a):
> >> I was wondering why building SVN with --with-kwallet requires NLS
> >> support to be on as well. r871309, which added the NLS check to
> >> SVN_LIB_KWALLET, does not explain why the change was made, and GNOME
> >> Keyring support, for example, doesn't require NLS to be enabled.
> >
> > There was compilation failure reported by Mark Phippard in #svn-dev on 2008-05-15:
> >
> > [20:15:28] <lisppaste4> markphip pasted "Arfrever: build error" at http://paste.lisp.org/display/60793
> >
> > I was able to reproduce compilation failure on 2008-05-16.
> > Today I cannot reproduce compilation failure with newer version of GCC, glibc, Qt and KDE...
>
> Thanks for the information. c++locale.h does not seem to exist in
> libstdc++ 4.7.1 in a Linux machine I have access to, and it does not
> include libintl.h on libstdc++ 4.2.1 here on FreeBSD.
>
> What else needs to be done for it to be decided whether it makes sense
> to remove the check now?
Send a patch that removes the check, ask people to test it on various
platforms, commit it if no one complains?
Received on 2012-09-01 22:42:34 CEST