[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] fix a crash in libsvn_wc

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 29 Aug 2012 13:00:46 +0200

The db pointer comes directly from svn_wc_context_t, which should come
directly from svn_client_ctx_t, where it is always added on proper
initialization using the constructor function

 

So while I agree that it should not crash, there is no way that any code
should reach this point without some calling problem.

 

Are you sure you create the svn_client_ctx_t using the constructor function?

 

(We had some earlier issues where users just created the struct and assumed
that initializing all the 1.6 members was enough to get 1.7 working. For 1.7
this is not enough)

 

                Bert

 

From: George Gugulea [mailto:gugulea_at_gmail.com]
Sent: dinsdag 28 augustus 2012 18:10
To: dev_at_subversion.apache.org
Subject: Re: [PATCH] fix a crash in libsvn_wc

 

[[[

Used from the kdevelop subversion plugin, the db pointers comes NULL. This
should be treated one way or another, I choose to return error and not an
assert because it might be a recoverable error. This should be reviewed and
an appropriate action should be taken.

]]]

 

attached is the patch for the last svn revision (1378109) of the file

-- 
gg
Received on 2012-08-29 13:01:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.