[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1376436 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 23 Aug 2012 14:49:01 +0100

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> - SVN_ERR(read_non_packed_revprop(proplist_p, fs, rev, generation,
>> - pool));
>> + {
>> + svn_error_t *err = read_non_packed_revprop(proplist_p, fs, rev,
>> + generation, pool);
>> + if (err)
>> + {
>> + if (!APR_STATUS_IS_ENOENT(err->apr_err)
>> + || ffd->format < SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT)
>> + return svn_error_trace(err);
>> +
>> + svn_error_clear(err);
>
> Are the output arguments of read_no_packed_revprop guaranteed (or unused) after this error clear + fall through?

*proplist_p is explicitly set to NULL before the call.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-08-23 15:49:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.