[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py tests/cmdline/svntest/actions.py

From: Mark Phippard <markphip_at_gmail.com>
Date: Tue, 21 Aug 2012 15:52:25 -0400

On Tue, Aug 21, 2012 at 3:46 PM, Branko Čibej <brane_at_wandisco.com> wrote:
> On 21.08.2012 21:37, Mark Phippard wrote:
>> On Tue, Aug 21, 2012 at 3:29 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:

>> FWIW, I agree it would be nice to have access to svn:log before the
>> data is sent from the client.
>
> I expect this would mean checking for log-file format conformance?

Yes. Users use the log file for lots of things that they might
validate in the pre-commit hook today. Could be conforming to some
kind of template or format, but it often is also something like
requiring a link to a bug ID, or some kind of "signed-off" by line
etc.

>> People could do a lot with that, and if
>> it is easier to attach the client version to the txn properties, then
>> that is another good reason.
>>
>> IMO, we have had a LOT of users@ requests for the client version in
>> hook scripts.
>
> Yeah, well, if these requests can also define what the client version
> actually is, we can start thinking about a solution. In the meantime,
> I'd prefer this information to not be mixed with revision properties;
> not least because I can't think of a way of preventing older servers
> from just writing such props into the repository.

Mike would have to answer that, but ISTR that the client/server
negotiation kept the client from sending this information. So older
servers would not get the props.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2012-08-21 21:52:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.