[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 4124] New - Give servers sufficient means to disallow commits from clients based on version numbers

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 20 Aug 2012 22:47:09 +0100

Mark Moe wrote on Mon, Aug 20, 2012 at 14:38:43 -0500:
> > Now, if we can find a way to expose the revprops to the start-commit hook,
> > all three RA layers should be able to provide early detection of commits
> > that would fail in pre-commit for revprop-related reasons. (And we should
> > consider this independently of the whole client-version capability stuff.)
>
> The ideal solution (for me) would be a start-commit hook that could
> query a temporary transaction that had everything (except actual file
> content) just like pre-commit can.

Mike covered the details, but the high-level is this: start-commit
_cannot_ have access to all the data that pre-commit can, for the simple
reason that the server receives some data from the client after
start-commit but before pre-commit. (And, naturally, if it weren't that
way, we would deprecate one of the hooks and subsume it into the other)

Specifically, start-commit is before the client uplods all the file
contents modifications.
Received on 2012-08-20 23:48:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.