[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] subversion issue #4174 - serf: checkout / export over https errors out with "svn: E730053: Error retrieving REPORT (730053)"

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sun, 19 Aug 2012 13:53:11 +0200

Hi Johan,

as you seem to be the only one encountering issue 4174, would you mind
testing attached serf patch?
You'll have to update serf trunk to r1627 to apply it cleanly.

It fixes the issue for me on Windows 7 with svn trunk and serf trunk.
While I have tested the patches on Mac OS X too, I couldn't reproduce
the original problem.

[[[
Fix https onnection abort issue when using https. This should fix
Subversion issue 4174:
http://subversion.tigris.org/issues/show_bug.cgi?id=4174

When the server sends us a "close notify" SSL Alert indicating that it's
going to close the socket, we have to stop sending on that socket immediately.

Failing to do so will make the server reset the connection, which can result
in an ECONNABORTED error upon next read or write. This seems to happen esp.
on Windows.

* buckets/ssl_buckets.c
  (ssl_decrypt): when SSL_read returns ok but with length 0, a "close notify"
   alert was received. Return APR_EOF to let upstream know that we're done
   with this socket.

* outgoing.c
  (read_from_connection): Add comment to note that SSL alert's are also an
   example of unexpected incoming data.
]]]

regards,

Lieven

Received on 2012-08-19 13:54:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.