RE: [PATCH] Don't strip Content-Type in .po files on Windows
From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Mon, 13 Aug 2012 11:06:48 +1000
I submitted this patch a couple of years ago, but it didn't get much attention. I still think it's relevant, so I'll try again.
GNU libintl, by default, converts the l10n strings into the locale encoding, while Subversion requires UTF-8. This conversion can be suppressed by calling bind_textdomain_codeset, but certain old versions of libintl don't have that, so the Unix build system checks for the existence of that function, and if it's not present, strips the Content-Type header from the .po files (which prevents encoding conversion, as well, but makes msgfmt complain).
When building on Windows, this stripping is done unconditionally, but is completely unnecessary:
- On Windows, we only support linking with svn-win32-libintl, which is hacked to disable all encoding conversions.
This patch removes Content-Type stripping on Windows, which gets rid of msgfmt warnings, as well as simplifies the build system.
* build/generator/build_locale.ezt: Remove the strip-po-charset.py invocation.
* build/strip-po-charset.py: Delete.
* subversion/svn_private_config.hw: Indicate that bind_textdomain_codeset is available if NLS is enabled.
This is an archived mail posted to the Subversion Dev mailing list.