[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS verifies rep-cache when disabled

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 1 Aug 2012 00:16:05 +0100

Bert Huijben wrote on Tue, Jul 31, 2012 at 22:11:31 +0200:
>
>
> > -----Original Message-----
> > From: MARTIN PHILIP [mailto:codematters_at_ntlworld.com] On Behalf Of
> > Philip Martin
> > Sent: dinsdag 31 juli 2012 21:30
> > To: Julian Foad
> > Cc: dev_at_subversion.apache.org
> > Subject: Re: FSFS verifies rep-cache when disabled
> >
> > Julian Foad <julianfoad_at_btopenworld.com> writes:
> >
> > > Philip Martin wrote:
> > >
> > >>& quot;svnadmin verify" verifies a rep-cache.db file even when
> > >> rep-caching is disabled. This appears to be intentional but I don't
> > >> understand the reasoning.
> > >>
> > >> svn_fs_fs__verify calls svn_fs_fs__exists_rep_cache to see if the
> > >> cache exists and then calls svn_fs_fs__walk_rep_reference which has
> > >> the comment:
> > >>
> > >> /* Don't check ffd->rep_sharing_allowed. */
> > >> SVN_ERR_ASSERT(ffd->format >=
> > SVN_FS_FS__MIN_REP_SHARING_FORMAT);
> > >>
> > >> Why should verify attempt to verify a cache that is disabled?
> > >
> > >
> > > I have a vague recollection that we argued at the time, that if and
> > > when the admin twiddles the knob to enable it, then it will be used
> > > without any further checking (or emptying) of it at that time, so it
> > > is part of the repository state that needs to be correct for the
> > > repository (including its knobs) to be considered 'verified good'.
> > > And that still makes sense to me.
>
> If it isn't enabled at all the performance cost of verifying is almost nil (but we shouldn't create the DB if it doesn't exist).

We don't, largely because you pointed that out in your commit review when
the above code was written.

Daniel
(I'm behind on my dev@ traffic, haven't read the other concurrent
threads I'm CC'd on yet)
Received on 2012-08-01 01:16:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.