Re: FSFS verifies rep-cache when disabled

Philip Martin wrote:

>& quot;svnadmin verify" verifies a rep-cache.db file even when rep-caching
> is
> disabled.  This appears to be intentional but I don't understand the
> reasoning.
>
> svn_fs_fs__verify calls svn_fs_fs__exists_rep_cache to see if the cache
> exists and then calls svn_fs_fs__walk_rep_reference which has the
> comment:
>
>   /* Don't check ffd->rep_sharing_allowed. */
>   SVN_ERR_ASSERT(ffd->format >= SVN_FS_FS__MIN_REP_SHARING_FORMAT);
>
> Why should verify attempt to verify a cache that is disabled?

I have a vague recollection that we argued at the time, that if and when the admin twiddles the knob to enable it, then it will be used without any further checking (or emptying) of it at that time, so it is part of the repository state that needs to be correct for the repository (including its knobs) to be considered 'verified good'.  And that still makes sense to me.

- Julian
Received on 2012-07-31 20:15:54 CEST