[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Revprop packing implemented

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Tue, 10 Jul 2012 18:09:13 +0200

On Tue, Jul 10, 2012 at 3:31 PM, Markus Schaber

> Hi, Stefan,
> Von: Stefan Fuhrmann [mailto:stefan.fuhrmann_at_wandisco.com]
> >> What's the performance penalty for modifying a packed rev props? From
> what you've said, it sounds like packing works by fitting as many rev props
> into a 64k chunk, so, let's say I've got a million rev repository. And the
> first 1000 revs fit neatly inside the first 64k pack. What happens when I
> propedit r1000 and increase its size so that it no longer neatly fits
> inside the 64k pack?
> > That one pack file gets split. I just committed a change that will
> result in two roughly equally sized pack files after the split - if the
> revprop sizes allow for it.
> Just to be sure: Did you catch the corner case where a revision X in the
> middle of the chunk gets a revprop that exceeds the 64k pack limit, and the
> code needs to split the Chunk into three (pre-X, X, post-X)?

Yes. There is even a test case for that. It tests "huge" revprops at the
in the middle and at the end of the pack file.

-- Stefan^2.

Certified & Supported Apache Subversion Downloads:
Received on 2012-07-10 18:09:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.