[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1359574 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 10 Jul 2012 12:15:06 +0100

stefan2_at_apache.org writes:

> Author: stefan2
> Date: Tue Jul 10 10:19:42 2012
> New Revision: 1359574

> + else
> + right_size += APR_ARRAY_IDX(revprops->sizes, right--, apr_off_t);
> + + SVN_INT64_BUFFER_SIZE;

../src/subversion/libsvn_fs_fs/fs_fs.c: In function ‘write_packed_revprop’:
../src/subversion/libsvn_fs_fs/fs_fs.c:4018: warning: statement with no effect

Also, putting right-- in a macro like APR_ARRAY_IDX relies on the macro
not expanding to use the parameter twice.

-- 
Philip
Received on 2012-07-10 13:15:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.