On Mon, Jul 9, 2012 at 11:40 AM, Philip Martin
<philip.martin_at_wandisco.com>wrote:
> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
> > On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin <
> philip.martin_at_wandisco.com>wrote:
> >
> >> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
> >>
> >> > This week I had one of my "how hard can it be?" moments
> >> > and finally implemented revprop packing (did that mainly
> >> > offline). It passes all tests and seems to work pretty well.
> >>
> >> There are buildbot failures, I don't know if they are caused by the
> >> packing code. valgrind gives me:
> >>
> >> The build bot failures are probably not caused by this.
> >
> >
> >> $ valgrind -q .libs/lt-fs-pack-test 1
> >> ==23822== Conditional jump or move depends on uninitialised value(s)
> >> ==23822== at 0x524F066: read_config (fs_fs.c:1118)
> >> ==23822== by 0x5264B15: pack_body (fs_fs.c:9571)
> >> ==23822== by 0x524DF5F: with_some_lock_file (fs_fs.c:614)
> >> ==23822== by 0x524E035: svn_fs_fs__with_write_lock (fs_fs.c:632)
> >> ==23822== by 0x5264F35: svn_fs_fs__pack (fs_fs.c:9636)
> >> ==23822== by 0x524CAA4: fs_pack (fs.c:273)
> >> ==23822== by 0x5039291: svn_fs_pack (fs-loader.c:526)
> >> ==23822== by 0x4020AA: create_packed_filesystem (fs-pack-test.c:200)
> >> ==23822== by 0x4024C5: pack_filesystem (fs-pack-test.c:290)
> >> ==23822== by 0x4E2EBDF: do_test_num (svn_test_main.c:265)
> >> ==23822== by 0x4E2F5E2: main (svn_test_main.c:525)
> >> ==23822==
> >>
> >> r1358977 fixes that.
> > Thanks for the feedback!
>
> This one:
>
> http://ci.apache.org/builders/bb-openbsd/builds/1612
>
> failed:
>
> FAIL: fs-pack-test 5: get/set revprop while packing FSFS filesystem
> FAIL: fs-pack-test 6: get/set large packed revprops in FSFS
>
> Perhaps r1358779 fixes it?
>
Yes, it should.
-- Stefan^2.
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-07-09 12:13:42 CEST