[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Revprop packing implemented

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Mon, 9 Jul 2012 11:05:44 +0200

On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin <philip.martin_at_wandisco.com>wrote:

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
> > This week I had one of my "how hard can it be?" moments
> > and finally implemented revprop packing (did that mainly
> > offline). It passes all tests and seems to work pretty well.
>
> There are buildbot failures, I don't know if they are caused by the
> packing code. valgrind gives me:
>
> The build bot failures are probably not caused by this.

> $ valgrind -q .libs/lt-fs-pack-test 1
> ==23822== Conditional jump or move depends on uninitialised value(s)
> ==23822== at 0x524F066: read_config (fs_fs.c:1118)
> ==23822== by 0x5264B15: pack_body (fs_fs.c:9571)
> ==23822== by 0x524DF5F: with_some_lock_file (fs_fs.c:614)
> ==23822== by 0x524E035: svn_fs_fs__with_write_lock (fs_fs.c:632)
> ==23822== by 0x5264F35: svn_fs_fs__pack (fs_fs.c:9636)
> ==23822== by 0x524CAA4: fs_pack (fs.c:273)
> ==23822== by 0x5039291: svn_fs_pack (fs-loader.c:526)
> ==23822== by 0x4020AA: create_packed_filesystem (fs-pack-test.c:200)
> ==23822== by 0x4024C5: pack_filesystem (fs-pack-test.c:290)
> ==23822== by 0x4E2EBDF: do_test_num (svn_test_main.c:265)
> ==23822== by 0x4E2F5E2: main (svn_test_main.c:525)
> ==23822==
>
> r1358977 fixes that.
Thanks for the feedback!

-- Stefan^2.

> --
> Cerified & Supported Apache Subversion Downloads:
> http://www.wandisco.com/subversion/download
>

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-07-09 11:06:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.