[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[RFC] Passing invalid uri to svn_ra_reparent causes JVM to abort when using JavaHL library (javahl-ra branch)

From: Vladimir Berezniker <vmpn_at_hitechman.com>
Date: Sun, 24 Jun 2012 13:17:54 -0400

Hi All,

While implementing svn_ra_reparent() function in JavaHL, I created a test
that
sends string "BAD" uri to the reparent function (I am trying to make sure
JavaHL can't take the JVM down). This causes segfault inside
uri_skip_ancestor() function of the line 1483 of the dirent_uri.c file:

  assert(svn_uri_is_canonical(child_uri, NULL));

which is called from svn_uri_skip_ancestor() function.

It seems a bit harsh to kill the whole JVM because caller passed a poorly
formed URI to a function, but I am not quite sure what would be the right
way of
addressing this. If someone could point me in a right direction I'll
prepare a
patch for review.

Thank you,

Vladimir
Received on 2012-06-24 19:18:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.