[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1352252 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 20 Jun 2012 14:30:07 -0400

On 06/20/2012 02:24 PM, gstein_at_apache.org wrote:
> + /* If we are talking to an old server, then the sha1-checksum property
> + will not exist. In our property parsing code, we don't bother to
> + check the <status> element which would indicate a 404. That section
> + needs to name the 404'd property, so our parsing code only sees:
> +
> + <g0:sha1-checksum/>
> +
> + That is parsed as an empty string value for the property.
> +
> + When checking the property, if it is missing (NULL), or the above
> + empty string, then we know the property doesn't exist.
> +
> + Strictly speaking, we could start parsing <status> and omit any
> + properties that were 404'd. But the 404 only happens when we ask
> + for a specific property, and it is easier to just check for the
> + empty string. Since it isn't a legal value in this case, we won't
> + get confused with a truly existent property. */

I remember writing ra_neon's PROPFIND parsing logic to parse the
per-property status field. Surely it can't be *that hard* to do the right
thing here, and stop conflating the empty string with a NULL one.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-06-20 20:30:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.