[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]: Add 'replaced' value to ConflictDescriptor.Reason

From: Dmitry Pavlenko <pavlenko_at_tmatesoft.com>
Date: Mon, 18 Jun 2012 21:10:41 +0200

Hi,

enum svn_wc_conflict_reason_t has 10 possible values but ConflictDescriptor.Reason from javahl only 6;
as I understand this is because some of svn_wc_conflict_reason_t values are "experimental" (for 1.8);
but anyway at least 1 of those values is released (svn_wc_conflict_reason_replaced that is for 1.7). So a corresponding value should be added to javahl.

If you accept this patch, I would also ask you to backport it to branches/1.7.x.

[[[
Add missing 'replace' value to ConflictDescriptor.Reason enum
corresponding to svn_wc_conflict_reason_replaced.

* subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
  (Reason): Add 'replace' value.
]]]
[[[
Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
===================================================================
--- subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java (revision 1351459)
+++ subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java (working copy)
@@ -241,6 +241,11 @@ public class ConflictDescriptor
          * Object is already added or schedule-add.
          */
         added;
+
+ /**
+ * Object is already replaced.
+ */
+ replaced;
     }
 
     public enum Operation
]]]
Received on 2012-06-18 21:12:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.