[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1139418 - in /subversion/trunk/subversion: libsvn_ra_serf/update.c mod_dav_svn/reports/update.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 15 Jun 2012 14:32:54 +0200

On 06/15/2012 01:41 PM, Ivan Zhakov wrote:
> On Fri, Jun 15, 2012 at 11:55 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>> On Mon, Jun 27, 2011 at 5:01 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>>> On 06/27/2011 10:30 AM, Ivan Zhakov wrote:
>>>> It would be nice to have sha1 checksum in liveprop collection (we
>>>> already have md5 checksum). This allow us optimize get_file() RA
>>>> request in future (get_file() request is actively used during merge)
>>>>
>>>> What do you think?
>>>
>>> Go for it!
>>>
>> Committed in r1350557.
>>
> Added client side support to ra_serf in r1350584.
>

On a related note: the merge code uses the public
svn_client_open_ra_session() everywhere, which doesn't provide any mechanism
for specifying a working copy (and by extension, a working copy
administrative area ... and by extension extension, a working copy
administrative area pristine store).

I've not yet decided how to fix this. Do we tweak
svn_client__open_ra_session_internal? Do we tweak
merge.c:ensure_ra_session_url? Do we rev svn_client_open_ra_session() so
that even third-party callers can get the benefits of the pristine cache,
and then propogate this new parameter up through the zillion wrapping
callers thereof?

*sigh*

It would be so nice to have our RA session management handled in one, sane,
relatively generalized, place.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-06-15 14:33:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.