Re: Changing the log API is not worth it

On Thu, Jun 14, 2012 at 5:46 PM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> Stefan Fuhrmann wrote:
>
>> Yesterday, I discovered an inconsistency in our log API.
>> svn_revnum_t is a long while the "limit" parameter is
>> an int.
>
> It is not semantically necessary to be able to request an arbitrarily large batch of log messages -- in other words, for the "limit" parameter to be the same as, or as big as, svn_revnum_t.
>
>> Since we have a practical limit of 2^31 on our revision
>> numbers
>
> Just curious: can you easily point to the source(s) of this practical limit?  I'm not particularly surprised, but I wasn't aware of it.

svn_revnum_t is a long, which is 32 bits on many systems. And given
that it is *signed*, then we realistically only support 2 billion
revisions in one repository.

Cheers,
-g
Received on 2012-06-15 11:19:09 CEST