[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Changing the log API is not worth it

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Thu, 14 Jun 2012 13:18:43 +0200

Hi all,

Yesterday, I discovered an inconsistency in our log API.
svn_revnum_t is a long while the "limit" parameter is
an int.

Since we have a practical limit of 2^31 on our revision
numbers and because int is (at least) 32 bits on all our
targets, switching the limit parameter to long is a pretty
much a mere formality.

The fix ripples through all ra layers and such blowing
the patch up to more then 700 lines. So, I think it is
simply not worth it.

-- Stefan^2.
Received on 2012-06-14 13:19:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.