[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1348130 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 12 Jun 2012 11:22:37 +0200

On 06/12/2012 04:34 AM, C. Michael Pilato wrote:
> On 06/10/2012 12:16 AM, Bert Huijben wrote:
>>> @@ -1214,7 +1215,11 @@ start_xml(void *userData, const char *ra
>>>
>>> svn_ra_serf__expand_ns(&name, parser->state->ns_list, raw_name);
>>>
>>> - parser->error = parser->start(parser, name, attrs, scratch_pool);
>>> + err = parser->start(parser, name, attrs, scratch_pool);
>>> + if (err && APR_STATUS_IS_EOF(err->apr_err))
>>
>> I know it is ugly but maybe you should use !SERF_BUCKET_READ_ERROR() instead of just APR_EOF. This should handle all specialized serf errors.
>
> Makes sense.

Done in r1349203.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-06-12 11:23:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.