[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1348130 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: Tue, 12 Jun 2012 08:42:23 +0200

On Tuesday, June 12, 2012, C. Michael Pilato wrote:

> On 06/10/2012 12:16 AM, Bert Huijben wrote:
> >> @@ -1214,7 +1215,11 @@ start_xml(void *userData, const char *ra
> >>
> >> svn_ra_serf__expand_ns(&name, parser->state->ns_list, raw_name);
> >>
> >> - parser->error = parser->start(parser, name, attrs, scratch_pool);
> >> + err = parser->start(parser, name, attrs, scratch_pool);
> >> + if (err && APR_STATUS_IS_EOF(err->apr_err))
> >
> > I know it is ugly but maybe you should use !SERF_BUCKET_READ_ERROR()
> instead of just APR_EOF. This should handle all specialized serf errors.
>
> Makes sense.

If it gives you any solace, Johan and I were up to 1am debugging his virus
scanning issue and it is almost certainly another instance of the EAGAIN
being ignored. =) -- justin
Received on 2012-06-12 08:42:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.