[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: AW: [PATCH]: Fix issue #4128

From: Philip Martin <philip_at_codematters.co.uk>
Date: Mon, 11 Jun 2012 16:08:03 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> Markus Schaber <m.schaber_at_3s-software.com> writes:
>
>> Here's the second iteration:
>>
>> [[[
>> libsvn_wc: no conflict for identical files
>>
>> [ in subversion/libsvn_wc ]
>>
>> * merge.c
>> (merge_file_trivial): Successful report merged when incoming file is identical to existing, locally modified file.
>>
>> [ in subversion/tests/cmdline ]
>> * update_tests.py
>> (update_binary_file_3): Remove XFAIL marker.
>>
>> ]]]
>
> Have you run the regression tests? I get:
>
> FAIL: merge_tests.py 1: performing a merge, with mixed results
> FAIL: merge_tests.py 70: cyclic merges don't add mergeinfo from own history
> FAIL: merge_tests.py 93: natural history filtering permits valid mergeinfo
> FAIL: update_tests.py 66: update locally modified file to equal versions
>
> The update test fail is because you need to set the expected_output to
> 'G '. I haven't looked at the others.

The patch uses tabs for indentation. Please use spaces.

-- 
Philip
Received on 2012-06-11 17:08:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.