[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: access violation fetching status

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 10 Jun 2012 13:49:02 +0200

On 10.06.2012 12:55, Bert Huijben wrote:
> When I look at the stack trace in this mail it appears that you call the
> status function with a NULL path. Why shouldn’t that fail at some level?
> You are supposed to provide a path, not NULL to our api 😊
> (I’m not sure if we can trust the rest of the stacktrace if you didn’t
> provide NULL)
> Bert

I don't think there's a chance that I would have passed NULL: all paths
and urls are first passed through svn_dirent_canonicalize() or for urls
svn_uri_canonicalize(). So either those functions would crash in case of
NULL paths, or an empty string would be returned. But not NULL.

And to be on the safe side here: I even check the paths I pass to
svn_client_status5 for empty strings first.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2012-06-10 13:49:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.