[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

abort on 'svn st'

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 09 Jun 2012 17:26:41 +0200

Hi,

Another one from the TSVN crash reports:

Several reports because of a call to SVN_ERR_MALFUNCTION_NO_RETURN()
when doing an 'svn st'. Stacktrace attached.

The call is in libsvn_subr/token.c:51

int
svn_token__from_word_strict(const svn_token_map_t *map,
                             const char *word)
{
   int value = svn_token__from_word(map, word);

   if (value == SVN_TOKEN_UNKNOWN)
     SVN_ERR_MALFUNCTION_NO_RETURN();

   return value;
}

but there's already a function svn_token__from_word_err() which does not
abort but return an error.

For an operation that's maybe the most used one (svn st) I'd rather have
an error than an abort().

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2012-06-09 17:27:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.