[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1346352 - in /subversion/trunk/subversion/libsvn_wc: questions.c wc_db.c wc_db.h workqueue.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 6 Jun 2012 00:30:54 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: dinsdag 5 juni 2012 17:11
> To: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1346352 - in
> /subversion/trunk/subversion/libsvn_wc: questions.c wc_db.c wc_db.h
> workqueue.c
>
> On Tue, Jun 5, 2012 at 7:31 AM, <rhuijben_at_apache.org> wrote:
> > Author: rhuijben
> > Date: Tue Jun  5 11:31:17 2012
> > New Revision: 1346352
> >
> > URL: http://svn.apache.org/viewvc?rev=1346352&view=rev
> > Log:
> > Revert r1346035, which exposed op_depth to more of the libsvn_wc api
> than
> > really necessary in preparation for a cleaner and even more optimized
> version.
>
> Thanks. Sounds like you have a new idea?

The only case that really needs optimization would be op_depth 0, called
from the working queue install operation. That could be expressed by a
Boolean instead of an int.

But it would be much cleaner to move most of that code in a new
svn_wc__db_pristine api, which would also allow using a db read lock to get
even higher performance during checkout and update.

        Bert
Received on 2012-06-06 00:31:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.