[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1340318 - in /subversion/trunk/subversion: libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py

From: Bert Huijben <bert_at_vmoo.com>
Date: Fri, 1 Jun 2012 23:52:00 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: vrijdag 1 juni 2012 23:46
> To: Philip Martin
> Cc: dev_at_subversion.apache.org; Bert Huijben
> Subject: Re: svn commit: r1340318 - in /subversion/trunk/subversion:
> libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
>
> On Fri, Jun 1, 2012 at 5:22 PM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
> > Greg Stein <gstein_at_gmail.com> writes:
> >
> >> On Fri, May 18, 2012 at 8:21 PM,  <rhuijben_at_apache.org> wrote:
> >>> Author: rhuijben
> >>> Date: Sat May 19 00:21:31 2012
> >>> New Revision: 1340318
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev
> >>> Log:
> >>> Avoid an unneeded ancestor check in the status walker. This has the
> added
> >>> benefit that api users can now see a different error code for not in a
> working
> >>> copy and not below a working copy.
> >>
> >> I just found this breaks stat 19 for me:

> >> Seems that check is needed :-P
> >
> > The test will FAIL when subversion/tests/cmdline/, or any directory
> > between there and /, is a working copy.  If subversion/tests/cmdline/ is
> > outside a working copy the test will PASS.
>
> Alright. Do you know how we can fix that? Our tests should not be
> sensitive to their placement in a filesystem. (otherwise, it isn't a
> very reliable test!)

Should be fixed by r1345361.

        Bert
Received on 2012-06-01 23:52:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.