[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash when upgrading wc

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 01 Jun 2012 21:22:05 +0200

Hi,

Again a post about some crash dumps that were sent for TSVN:

When upgrading a working copy, there's an abort() called here:
subversion\subversion\libsvn_wc\util.c, 300:
(svn_uri_is_canonical(repos_url, pool) &&
  svn_relpath_is_canonical(path_in_repos) && SVN_IS_VALID_REVNUM(peg_rev))

problem in this case: the 'repos_url' looks like this:
https://xxx.xx.xxx.192:443/svn/

now, in 1.6.x this was a valid canonical url. In 1.7 however, having the
port number in the url if it's the default port makes
svn_uri_is_canonical() return FALSE.

Fine by me, but when upgrading, this should be handled much better than
with an abort() call!

stacktrace attached.

crash dumps (26) available here:
https://www.crash-server.com/Problem.aspx?ClientID=tsvn&ProblemID=1170

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2012-06-01 21:22:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.