Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check C++ pointer extracted from the java object

+1
On May 31, 2012 11:25 PM, "Vladimir Berezniker" <vmpn_at_hitechman.com> wrote:

> I applied the patch to the javahl-ra branch instead of the trunk by
> mistake, is
> it ok if a cherry pick it onto trunk?
>
> Sorry about that,
>
> Vladimir
>
> On Thu, May 31, 2012 at 3:37 AM, Greg Stein <gstein_at_gmail.com> wrote:
>
>> On Thu, May 31, 2012 at 3:35 AM, Greg Stein <gstein_at_gmail.com> wrote:
>> >...
>> > Fix the above three problems, and I'm +1 for you to commit just patch
>> #1.
>>
>> To clarify: I trust you to make the three changes, and you're free to
>> commit with my +1. I don't need another round of review.
>>
>> (if something is missing, then we can fix in a second commit)
>>
>> Thanks,
>> -g
>>
>
>
Received on 2012-06-01 09:51:51 CEST