Re: svn commit: r1344347 - /subversion/trunk/subversion/libsvn_subr/config_file.c

Greg Stein <gstein_at_gmail.com> writes:

> On Thu, May 31, 2012 at 4:39 AM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
>> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>>
>>> Config files are also used for authz settings and they can be even
>>> more than 100 MB in real world scenarios.
>>
>> Yes, particularly for setups that use SVNParentPath but not the new
>> AuthzSVNReposRelativeAccessFile.
>
> Woah. Wait a second here.
>
> My understanding is that these are read on *every* request (per
> Daniel). Are you suggesting that we are reading/parsing 100 Mb on
> every request?
>
> There is something wrong here. 100 Mb config files are flat out wrong.
> We should be doing better. And if we are *actually* parsing those
> per-request, then we've gone off the deep-end.

We cache the parsed data in the connection pool, see
mod_authz_svn.c:get_access_conf, so it's per-connection rather than
per-request. That's still not brilliant.

I'm not sure whether the SVNParentPath case discards parsed data for
repositories that are not the one in the current request.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com