Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

On Tue, May 29, 2012 at 5:01 PM, Dustin Lang <dstn_at_astro.princeton.edu> wrote:
>...
>> You can use svn_sort_compare_items_lexically because entries are single
>> path components that do not contain slashes. In which case
>> svn_sort_compare_items_as_paths produces the same result but is less
>> efficient.
>
> The paths are like:
>
>  trunk/documents/papers/archetypes/paper_plots/103lg.ps
>
> But I still believe you are right that lexical sort will work fine and is
> simpler than svn_sort_compare_items_as_paths.

Right. Everything up to the final '/' will match precisely, so only
the children are being compared.

More specifically, you are NOT sorting paths like:

  some/path
  some/path/more
  some/pathmore

The sorting there is quite a bit different.

>...

Thanks for the patch! Stefan or I will get it applied. Any further
tweaks can be applied in a later revision.

Cheers,
-g
Received on 2012-05-30 02:09:38 CEST