[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue #4134 (partial): sort deleted nodes before dumping them

From: Dustin Lang <dstn_at_astro.princeton.edu>
Date: Tue, 29 May 2012 15:09:08 -0400 (EDT)

Hi,

This is my first time working on the subversion code, so be gentle :)

I believe the attached patch solves one component of #4134 ("svnadmin dump files
are not reproducible, due to APR 1.4.6 hash order changes"), namely that deleted
nodes are stored in a hash and dumped out in (now-arbitrary) hash iteration
order. This patch simply uses "svn_sort_hash" to get a sorted view of the keys
before dumping them.

I have verified that it runs valgrind-clean when "svnadmin dump"ing >700 revs of
the astrometry.net repo (and now my repo and its svnsync'd mirror produce
exactly equal dumps, hoorah), but I don't really know if I've used the apr
infrastructure appropriately.

I don't know whether this completely solves #4134; it works for me, but my repo
is simple.

cheers,
dustin

http://subversion.tigris.org/issues/show_bug.cgi?id=4134

Received on 2012-05-29 21:09:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.