[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: File permissions are incorrect after directory copy in 1.7

From: Fergus Slorach <sugref_at_gmail.com>
Date: Mon, 28 May 2012 22:59:58 +1200

On 05/28/2012 09:06 PM, Philip Martin wrote:
> Fergus Slorach<sugref_at_gmail.com> writes:
>
>> If a directory containing svn:needs-lock files is copied and
>> committed, the needs-lock files are left writeable.
>
> I think that is correct behaviour.

The problem is that a needs-lock file should not be writeable without
being locked.

Note that the behaviour is different when the file is copied:

/tmp/copy_test/foo> svn cp bar.txt baz.txt
A baz.txt

/tmp/copy_test/foo> ls -l
total 0
-r--r--r-- 1 fergus fergus 0 2012-05-28 22:44 bar.txt
-rw-rw-r-- 1 fergus fergus 0 2012-05-28 22:45 baz.txt

/tmp/copy_test/foo> svn commit -m 'Copied'
Adding baz.txt

Committed revision 2.
nexus:/tmp/copy_test/foo> ls -l
total 0
-r--r--r-- 1 fergus fergus 0 2012-05-28 22:44 bar.txt
-r--r--r-- 1 fergus fergus 0 2012-05-28 22:45 baz.txt

This is the correct behaviour - the new file is writeable after the
copy, but is made read-only by the commit.

>> The writeable state can be resolved by running 'svn revert' on
>> the files, even though the status indicates there is nothing to
>> revert.
>
> That looks wrong, the file should remain writeable. Fixed by r1343168.
>

Revert does the right thing by making the file read-only but that
should have been done by the commit, as in the file case above.

Thanks,

fergus
Received on 2012-05-28 13:00:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.