[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 24 May 2012 12:45:55 +0200

On Thu, May 24, 2012 at 11:32:42AM +0100, Philip Martin wrote:
> I don't like it. The email doesn't contain the patch or the log
> message. The email has the address of the patch author in the body and
> not in the headers. Patches should be visible and discussed on dev.
>
> Since you mention it: I think submitting patches as "attachments" through
> subversion.tigris.org is broken as well. Getting an email telling me a
> patch has been added to an issue but not sending me the patch itself is
> unhelpful.

+1

Email is my primary interface to the community and it works
well for me. Keeping track of what happens at external websites
people use to manage their code is an extra burden for me. I want to
review patches and log messages in my mail reader and/or editor,
not in a web browser. And I want to be able to follow patch submission
reviews made by others, without tracking separate channels.

We have a saying that "if it didn't happen on dev@, it didn't happen".
I would appreciate if that applied to patch submissions, too.

The above is not a statement on how other ASF projects should
handle patch submissions. Each project should define their own
way of handing patch submissions. Patch submitters should provide
patches in a way the project is prepared to handle.
Received on 2012-05-24 12:46:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.