[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 24 May 2012 10:52:54 +0100 (BST)

Greg Stein wrote:
> I moderated this through, in order to start a discussion.
>
> My feeling is: this is not how we want to accept patches. This
> approach is completely disconnected from our community. How do we talk
> to the person providing the change? How do we ask for modifications?
> How to interact?

About this particular pull request:  The patch just makes two apparently unrelated trivial changes in one of our example scripts.  It looks like it could easily be somebody just experimenting with using Git -- maybe they pressed the "pull request" button by mistake.  I sent a query, pointing out our current submission procedure is currently required.

> But even larger: our goal is to get people *involved* in our
> community. There isn't any obvious way to get 'techtonik' brought into
> our community unless they come to the dev@ list.

About the principle of accepting
pull requests:  At this time, I'd say unquestionably a dev-list
presentation is required.  But I'd be open to suggestions of how we can start to
use the GitHub channel as part of our submission process as well, if we
want to.

- Julian

> That said... we *do* accept patches via the issue tracker on
> subversion.tigris.org. Are we ready to accept patches through a
> separate channel? Personally, I'm not ready to say "hey, any channel
> on the planet is fine. please... feel free! devise new channels! we
> are willing to review 100 channels for incoming patches!"
>
> I like GitHub. It is a very, very well-done site. But I'm not ready to
> say that it is a viable mechanism for people to deliver patches. My
> preference is for those to arrive here on dev@, where we can interact
> with the person. Not as some drive-by, fait accompli.
>
> Thoughts?
> -g
>
>On Thu, May 24, 2012 at 4:12 AM, Git at Apache <git_at_git.apache.org> wrote:
>> GitHub user techtonik opened a pull request:
>>
>>    https://github.com/apache/subversion/pull/1
>>
>>    port to new style classes - http://stackoverflow.com/questions/54867/old...

[...]
Received on 2012-05-24 11:53:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.