Re: svn commit: r1341031 - /subversion/trunk/subversion/svn/props.c

On May 21, 2012 11:06 AM, "Hyrum K Wright" <hyrum.wright_at_wandisco.com>
wrote:
>
> On Mon, May 21, 2012 at 9:03 AM, <stsp_at_apache.org> wrote:
> > Author: stsp
> > Date: Mon May 21 14:03:46 2012
> > New Revision: 1341031
> >
> > URL: http://svn.apache.org/viewvc?rev=1341031&view=rev
> > Log:
> > Make 'svn proplist' print property lists in sorted order.
> > Avoids random output ordering with APR-1.4.6.
>
> If we do this on a regular basis, it might be useful to implement a
> wrapper which takes a baton and handler function and then calls the
> handler with the hash key/value in sorted order. It might add some
> overhead, but it also consolidates the sorting into one location,
> rather than sprinkled everywhere. It doesn't matter much to me; just
> a thought that arose upon review. :)

We have svn_iter.h already, and I hate it. Setting up a baton and a
function to avoid a for-loop sucks.

An encapsulated iterator might be nice, however. Essentially a replacement
for apr_hash_index_t.

Cheers,
-g
Received on 2012-05-21 20:39:15 CEST