[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1340556 - /subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 19 May 2012 20:19:54 -0400

On May 19, 2012 4:31 PM, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c Sat May 19
20:30:55 2012
>...
> @@ -459,48 +460,60 @@ svn_wc__db_wcroot_parse_local_abspath(sv
> database in the right place. If we find it... great! If not, then
> peel off some components, and try again. */
>
> + adm_relpath = svn_wc_get_adm_dir(scratch_pool);
> while (TRUE)
> {
> svn_error_t *err;
> + svn_node_kind_t adm_subdir_kind;
>...
> + const char *adm_subdir = svn_dirent_join(local_abspath,
adm_relpath,
> + scratch_pool);
> +
> + SVN_ERR(svn_io_check_path(adm_subdir, &adm_subdir_kind,
scratch_pool));
> +
> + if (adm_subdir_kind == svn_node_dir)

Comment? Let's prevent somebody taking this out, and just relying on the
following tests to fail.

Again the comment was in the log message, not the code.

>...

Cheers,
-g
Received on 2012-05-20 02:20:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.