[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ISSUE: "To many open files" not being logged by master server when sync fails.

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 16 May 2012 17:05:18 +0100

Kenneth Miles <kmiles_at_voyagergaming.com> writes:

> On 04/05/12 20:09, Philip Martin wrote:
>> Kenneth Miles<kmiles_at_voyagergaming.com> writes:
>>
>>
>>>> I'm not sure if a specific revision is causing the issue. But it
>>>> always fails replaying on a certain revision number as seen in the
>>>> stack trace.
>>>>
>>>> It is definitely opening multiple files more than once. It closes
>>>> all file handles once the abort-edit is sent.
>>>>
>>>> Can i check anything else?
>>>>
>>>>
>>> There are 1054 file adds and 1054 property changes on those files.
>>>
>> I can't reproduce it. Are you able to come up with a complete recipe?
>> Starting with "svnadmin create", doing a checkout, adding files, setting
>> properties, commiting, "svnsync init", etc.
>>
>> Failing that can you tell us which files are open? Look in /proc/NNN/fd
>> or perhaps
>>
>> strace -etrace=open,close -fp NNN
>>
>> where NNN is the svnserve process ID will help.
>>
>>
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487
> /tmp/work/svn/egm/db/revs/1/1487

You didn't say whether these are the files opened sequentially during an
strace run or files open simultaneously from /proc/NNN/fd.

I'm still not able to reproduce the bug. Which version of svnserve are
you running? If you do:

 svnadmin create ...
 svnsync init ...
 svnsync sync ...

to get a fail and then you repeat
 
 svnsync sync ...

does it fail a second time? If it fails a second time that indicates a
problem with that one revision, otherwise it may be a problem that
accumulates over multiple revisions.

When you say:

 "There are 1054 file adds and 1054 property changes on those files."

are those simple adds, or are they copies? Are they all in one dir or
spread out over multiple dirs?

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2012-05-16 18:05:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.