[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: paths in diff output (possible bug)

From: Dmitry Pavlenko <pavlenko_at_tmatesoft.com>
Date: Tue, 15 May 2012 01:16:44 +0200

Hi Stefan,

I'll have a look a bit later. But from the first glance I've found a couple of suspicious places. I
do not state that they are wrong or that I have a counterexample, but just not clear for me.

1. When you call callbacks->dir_props_changed for added properties, you convert them to regular, but
for deleted properties you do not (and the same is true for file properties diff).

2. In diff_repos_repos_added_or_deleted_dir in "for" cycle you use different pools (iterpool and
scratch_pool).

> On Thu, May 03, 2012 at 10:05:26PM +0200, Dmitry Pavlenko wrote:
> > Thanks, Stefan,
> > I like the approach of a fake checkout. Actually this is what I meant by
> > proposing to handle this case separatedly.
>
> Hi again Dmitry,
>
> can you please check if r1338291 fixed diff output as expected? Thanks!
Received on 2012-05-15 01:18:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.