[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1337388 - /subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 14 May 2012 14:07:42 -0400

On May 14, 2012 3:50 AM, "C. Michael Pilato" <cmpilato_at_collab.net> wrote:
>
> On 05/11/2012 05:40 PM, gstein_at_apache.org wrote:
> > Author: gstein
> > Date: Fri May 11 21:40:55 2012
> > New Revision: 1337388
> >
> > URL: http://svn.apache.org/viewvc?rev=1337388&view=rev
> > Log:
> > Note a problem. The new xml parsers should correct issues like this.
> >
> > * subversion/libsvn_ra_serf/get_deleted_rev.c:
> > (cdata_getdrev): this function could be invoked N times with a
> > single character of the revision. the approach used here is wrong.
> > leave a marker noting that.
>
> ... and these aren't merely theoretical problems -- I've run into several
> real-world incidences of this sort before. Need to use a stringbuf to
> collect all the CDATA, and transfer to the preferred storage
location/format
> in the end-tag handler.

Yup, exactly! The new code does this properly and automagically, so we
won't see these odd one-off errors. This specific code has already been
upgraded.

Cheers,
-g
Received on 2012-05-14 20:08:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.