Re: svn commit: r1337281 - /subversion/trunk/subversion/libsvn_client/commit_util.c

On Fri, May 11, 2012 at 12:50 PM, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/commit_util.c Fri May 11 16:50:31 2012
>...
> @@ -642,7 +644,29 @@ harvest_status_callback(void *status_bat
>
>   baton->got_one = TRUE;
>
> -  SVN_ERR_ASSERT(svn_dirent_is_absolute(local_abspath));
> +  if (baton->skip_below_abspath
> +      && svn_dirent_is_ancestor(baton->skip_below_abspath, local_abspath))
> +    {
> +      return SVN_NO_ERROR;
> +    }
> +  else
> +    baton->skip_below_abspath = NULL; /* We have left the skip tree */
> +
> +  switch (status->node_status)
> +    {
> +      case svn_wc_status_unversioned:
> +      case svn_wc_status_ignored:
> +      case svn_wc_status_external:
> +      case svn_wc_status_none:
> +        return SVN_NO_ERROR;
> +      case svn_wc_status_normal:
> +        if (!copy_mode && !status->conflicted)
> +          return SVN_NO_ERROR;
> +        break;

It is unclear why you skip this node. What is that condition testing
for? Could you please explain in a comment?

A generic comment for the whole switch would be nice, too.

>...

Cheers,
-g
Received on 2012-05-12 04:28:22 CEST