[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1336128 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 10 May 2012 13:36:47 +0200

On Wed, May 09, 2012 at 11:57:29PM -0400, Greg Stein wrote:
> On Wed, May 9, 2012 at 10:07 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> > The parameter is new in 1.8. The ignoreProps parameter is new in 1.8, too,
> > and I modeled my changes on those that added the ignoreProps parameter.
> >
> > So I suppose this change is alright?
>
> Nope. People coding to the 1.7 API will not be providing that
> parameter. Thus, it will not compile.
>
> You need to define new methods that include the parameter, to
> supplement the existing methods that do not have it. (yay,
> polymorphism!)

Yes, that's the approach to take when changing the 1.7 variant.

However, according to Mark I was actually changing the 1.8 variant.
The API was already "bumped" earlier by Hyrum (ignoreProps and something
else is new in 1.8, too).
Received on 2012-05-10 13:37:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.