Re: svn commit: r1336128 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/

On Wed, May 09, 2012 at 09:59:39AM -0400, Mark Phippard wrote:
> On Wed, May 9, 2012 at 8:18 AM, <stsp_at_apache.org> wrote:
> > Author: stsp
> > Date: Wed May  9 12:18:37 2012
> > New Revision: 1336128

> > @@ -561,7 +563,7 @@ public interface ISVNClient
> >               OutputStream outStream,
> >               Depth depth, Collection<String> changelists,
> >               boolean ignoreAncestry, boolean noDiffDeleted, boolean force,
> > -              boolean copiesAsAdds, boolean ignoreProps)
> > +              boolean copiesAsAdds, boolean ignoreProps, boolean propsOnly)
> >             throws ClientException;
>
> I do not know if these methods are new in 1.8, but if not, then this
> is the public API. So for compatibility you have to add a new method
> with the new additional options. You do not need to add a "2" or
> anything to the method name since Java does not require that, just add
> another method to the interface.

The parameter is new in 1.8. The ignoreProps parameter is new in 1.8, too,
and I modeled my changes on those that added the ignoreProps parameter.

So I suppose this change is alright?
Received on 2012-05-09 16:07:55 CEST