[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1335566 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 9 May 2012 00:21:51 +0400

On Tue, May 8, 2012 at 11:10 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 05/08/2012 02:20 PM, Ivan Zhakov wrote:
>>> +/* Implements svn_close_fn_t */
>>> +static svn_error_t *
>>> +close_handler_lazyopen(void *baton)
>>> +{
>>> +  lazyopen_baton_t *b = baton;
>>> +
>>> +  SVN_ERR(lazyopen_if_unopened(b));
>>> +  SVN_ERR(svn_stream_close(b->real_stream));
>>
>> I think we should just no-op in case if wrapped stream is not opened. I meant:
>> [[[
>> if (opened)
>> {
>>    SVN_ERR(svn_stream_close(b->real_stream));
>> }
>> return SVN_NO_ERROR;
>> ]]]
>
> I'm 50/50 on this change of behavior, but you clearly have an opinion, so
> I've changed (and documented) it.  See r1335704.
>
Thanks Mike!

-- 
Ivan Zhakov
Received on 2012-05-08 22:22:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.