[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1335566 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 8 May 2012 14:48:13 -0400

On Tue, May 8, 2012 at 2:38 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 05/08/2012 02:25 PM, Greg Stein wrote:
>...
>> Per my suggestion on IRC, I don't see how this function can ever
>> error, or ever need a scratch_pool (no matter how we might
>> extend/upgrade it). I'd suggest updating the signature accordingly.
>
> I removed the scratch_pool from svn_stream_lazyopen_create() already, but
> forgot about the "don't return an error" bit.  Will fix.
>
> I *did* preserve the scratchpool in the open_func() callback, though, and
> the one implementation thereof uses it to pass to
> svn_wc__db_pristine_read().  But if you think that's unnecessary too, I can
> pull it.

Nope. I completely agree with your design on that part!

Cheers,
-g
Received on 2012-05-08 20:48:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.