Re: Deletion revision in Ev2

On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright
<hyrum.wright_at_wandisco.com> wrote:
>...
> In this case, we are legitimately deleting B/C, but the "revision this
> thing is being deleted from" doesn't exist until commit finalization.

True. I figured as the FS, we always had a revision... but that's not true :-P

>...
> Simply eliminating the check in editor.c:delete_cb(), and also
> changing can_modify() to allow invalid revision to act as a wildcard
> (i.e., "don't bother checking, I know this should be modifiable")
> makes the test pass, but I don't know that that's the generally
> correct solution.

It is valid. I'll make the necessary changes.

Cheers,
-g
Received on 2012-05-07 20:43:47 CEST