[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1334244 - in /subversion/trunk/subversion: include/svn_editor.h libsvn_delta/compat.c libsvn_delta/editor.c libsvn_fs/editor.c libsvn_repos/commit.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 5 May 2012 13:50:59 -0400

On Sat, May 5, 2012 at 1:40 PM, Hyrum K Wright
<hyrum.wright_at_wandisco.com> wrote:
> On Fri, May 4, 2012 at 5:49 PM,  <gstein_at_apache.org> wrote:
>...
>> Author: gstein
>> @@ -885,8 +890,16 @@ svn_editor_add_absent(svn_editor_t *edit
>>  * (e.g. it has not yet been committed), then @a revision should be
>>  * #SVN_INVALID_REVNUM.
>>  *
>> - * For a description of @a props, see svn_editor_add_file(). @a props
>> - * may not be NULL.
>> + * If any changes to the set of children will be made in the future of
>> + * the edit drive, then @a children MUST specify the resulting set of
>> + * children. See svn_editor_add_directory() for the format of @a children.
>> + * If not changes will be made, then NULL may be specified.
>
> In this context "changes" means additions, deletions or replacements,
> correct?  It might be worth it to explicitly call out the fact that
> changes to contents of children (whether they be directories or files)
> do not constitute a need to supply this parameter.

Not replacements. Just things that add/remove children.

I'll think about how to best expand/clarify the docstring. Please feel
free if you are feeling creative...

Cheers,
-g
Received on 2012-05-05 19:51:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.