[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1330058 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs/editor.c libsvn_repos/commit.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 27 Apr 2012 20:37:28 +0300

Philip Martin wrote on Fri, Apr 27, 2012 at 18:29:09 +0100:
> Perhaps we should keep the current behaviour and return both an error
> and a path and let the caller decide which to one use.

We could use the existing svn_error_t ** argument for that; the
semantics would be that it is the post-commit error when
SVN_IS_VALID_REVNUM(*revision), the conflict error when *conflict_path
is set, and has an unspecified value if the commit failed for a reason
other than a conflict.
Received on 2012-04-27 19:38:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.