Re: svn commit: r1330058 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs/editor.c libsvn_repos/commit.c

Greg Stein <gstein_at_gmail.com> writes:

> On Wed, Apr 25, 2012 at 16:43, Philip Martin <philip.martin_at_wandisco.com> wrote:
>> Perhaps we should keep the error and toss the path?
>
> mod_dav_svn uses that path to construct a "nice" error message based
> on the context of the commit.

mod_dav_svn isn't the only user of this API.

>> So currently reporting "conflict on path 'foo'" is probably sufficient
>> but it's odd to limit ourselves.  We have an error reporting mechanism
>> why would we choose not to use it?
>
> Well... we return that conflict_path so that callers can make
> nicer/contextual error messages with the path. We don't transfer the
> whole chain over the wire, so if the path is on the inner error (say,
> if we just wrapped context and relied on the path to be in the inner
> error), then the user would never see the path.
>
> If we could/would marshal the whole error chain, then yes: we could
> rely on our error reporting mechanism. But we don't, so we can't.

svnserve returns an error chain, see svn_ra_svn_write_cmd_failure.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com