Am 26.04.2012 11:14, schrieb Daniel Shahaf:
> stefan2_at_apache.org wrote on Fri, Apr 13, 2012 at 18:36:46 -0000:
>> svn_error_t *svn_ra_svn_write_cstring(svn_ra_svn_conn_t *conn,
>> apr_pool_t *pool, const char *s)
>> {
>> + else
>> + write_number(conn, pool, len, ':');
> Error leak
Fixed in r1331228.
>> Modified: subversion/trunk/subversion/libsvn_ra_svn/ra_svn.h
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/ra_svn.h?rev=1325899&r1=1325898&r2=1325899&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_ra_svn/ra_svn.h (original)
>> +++ subversion/trunk/subversion/libsvn_ra_svn/ra_svn.h Fri Apr 13 18:36:46 2012
>> @@ -57,8 +57,8 @@ typedef svn_error_t *(*ra_svn_block_hand
>> void *baton);
>>
>> /* The size of our per-connection read and write buffers. */
>> -#define SVN_RA_SVN__READBUF_SIZE 4096
>> -#define SVN_RA_SVN__WRITEBUF_SIZE 4096
>> +#define SVN_RA_SVN__READBUF_SIZE 4*4096
>> +#define SVN_RA_SVN__WRITEBUF_SIZE 4*4096
>>
> Parentheses please? (May not be strictly necessary, but I shouldn't
> have to reach for the man page to check whether there is an operator
> that binds more tightly than * and is applicable here.)
>
Fixed in r1331226.
Thanks for the review!
-- Stefan^2.
Received on 2012-04-27 07:47:07 CEST