Re: svn commit: r1329563 - /subversion/trunk/subversion/libsvn_fs/editor.c

gstein_at_apache.org wrote on Tue, Apr 24, 2012 at 06:07:18 -0000:
> @@ -94,9 +210,11 @@ add_absent_cb(void *baton,
> svn_revnum_t replaces_rev,
> apr_pool_t *scratch_pool)
> {
> - struct edit_baton *eb = baton;
> -
> - UNUSED(eb); SVN__NOT_IMPLEMENTED();
> + /* This is a programming error. Code should not attempt to create these
> + kinds of nodes within the FS. */
> + return svn_error_create(
> + SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> + N_("The filesystem does not support 'absent' nodes"));
> }

Should be _() not N_()

Also: change the error text and code? The use of "unsupported" sounds
like a format upgrade would fix it. How about one of those "is not
allowed, and could indicate a bug in your client" errors?

SVN_ERR_EDITOR_INVALID_OPERATION maybe.
Received on 2012-04-25 13:04:19 CEST